remove mounting vsphere-config-secret in vsphere-csi-node daemonset #181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR is removing mounting of vsphere-config-secret in vsphere-csi-node daemonset pods.
vsphere-config-secret
is only required on node daemonset when topology feature is to be used.This is required in the topology aware setup so that node can determine its topology by connecting to vCenter, to publish
AccessibleTopology
in theNodeGetInfoResponse
.Why we need this change now?
this change was already present in
v1.0.2
, but while merging development repository, this change was missed in this PR - #151@RaunakShah added this fix in
v1.0.2
- 136e3ecSpecial notes for your reviewer:
Verified correctness in the yaml change with deploying driver using this updated yaml and latest image.
Also verified basic provisioning workflow.
Release note: